History: Organization of button colors in Tiki

• «
• »

            {HTML(wiki="0")}
<style>
.newbutton {
  display: inline-block;
  padding: 6px 12px;
  margin-bottom: 0;
  font-size: 14px;
  font-weight: 400;
  line-height: 1.42857143;
  text-align: center;
  white-space: nowrap;
  vertical-align: middle;
  -ms-touch-action: manipulation;
  touch-action: manipulation;
  cursor: pointer;
  -webkit-user-select: none;
  -moz-user-select: none;
  -ms-user-select: none;
  user-select: none;
  background-image: none;
  border: 1px solid rgba(0, 0, 0, 0);
  border-radius: 4px;
}

.newprimary {
  color: rgb(255, 255, 255);
  background-color: rgb(51, 122, 183);
  border-color: rgb(46, 109, 164);
}

.newsuccess {
  color: rgb(255, 255, 255);
  background-color: rgb(92, 184, 92);
  border-color: rgb(76, 174, 76);
}

.newinfo {
  color: rgb(255, 255, 255);
  background-color: rgb(91, 192, 222);
  border-color: rgb(70, 184, 218);
}

.newwarning {
  color: rgb(255, 255, 255);
  background-color: rgb(240, 173, 78);
  border-color: rgb(238, 162, 54);
}

.newdanger {
  color: rgb(255, 255, 255);
  background-color: rgb(217, 83, 79);
  border-color: rgb(212, 63, 58);}

.newsecondary {
    color: rgb(255, 255, 255);
    background-color: #6d35a6;
    border-color: #6d35a6;
}</style>
{HTML}

The goal here is to make the meaning of button colors in Tiki more intuitive and consistent, at least in the Bootstrap Default theme, as a baseline. Of course every theme has its own color palette and button colors vary from the default.

In Bootstrap 4, which is integrated into Tiki 19 and newer, some button class names and default colors have changed from Bootstrap 3. (See [https://getbootstrap.com/docs/4.3/components/buttons/] .) The meanings conveyed by button colors may not be as clear now as they were in Bootstrap 3, when the default button color was essentially neutral and colors were used for special meaning and, even with Tiki and Bootstrap 3, there wasn't a clear pattern of button color use. 

For this reason, the button classes are being organized in the .tpl files, etc. and will be in the HTML and they will be most apparent in the Default Bootstrap theme. Other themes, of course, can style buttons as they please but the hope is that the organization of button colors makes sense and will benefit themes and users even if the themes' palettes vary from the Bootstrap default.

One suggestion is that sites could assign an admin theme that shows the button colors most clearly, and another site theme with perhaps less obvious colors that are toned down from the default ones.

|| __Button purpose__ | __CSS class, and color in Bootstrap default theme__ | __Action examples__
Make a significant non-destructive change | btn-primary (royal blue -#007bff) {HTML()}<button class="newbutton newprimary">Primary</button>{HTML} | Save, Apply, Rename, Select, Attach 
Confirmation for non-destructive change | btn-success (green)  {HTML()}<button class="newbutton newsuccess">Success</button>{HTML} | Anti-CSRF confirmation
Make a destructive change | btn-danger (red) {HTML()}<button class="newbutton newdanger">Danger</button>{HTML} | Delete, Remove 
Confirmation for destructive change | btn-warning (yellow)  {HTML()}<button class="newbutton newwarning">Warning</button>{HTML} | Are you sure? 
Display information%%%{TAG(tag="small")}Including buttons that navigate to another page to show content.{TAG} | btn-info (turquoise blue - #17a2b8)  {HTML()}<button class="newbutton newinfo">Info</button>{HTML} | History, Source, Preview, Find 
Make an insignificant change%%%{TAG(tag="small")}Including buttons that show/hide content without a page change.{TAG} | btn-secondary ("cyber grape")  {HTML()}<button type="button" class="newbutton newsecondary">Secondary</button>{HTML} | Tabs/No tabs, Sort, Filter, Files, Comments, More ||

* In principle, links that are used for navigation should be styled as [#|links] (text only or text with icon), not as buttons. But there can be exceptions such as widgets which call an action and also link to another page. Then -+btn-link+- can be used. For example: {button href="#" _text="This is a small button link!" _type="link" _class="btn-sm"}
* On pages or sites where there aren't many buttons, the button colors might seem random, but as the number of buttons and user interactions increases, then hopefully the color pattern will be more evident and useful from a UI standpoint.
* For consistency this semantic scheme should be applied to icon buttons as well, like the magnifying-glass "search" icon and the "i" and "?" tooltip icons, in forms and so on, but not in an array like the admin icons where color consistency is more important.

Dev mailing list discussion starts here: [https://sourceforge.net/p/tikiwiki/mailman/message/36346433/] 

!! Edge cases
* The __Post new comment__ button leads eventually to a positive action so could possibly be considered ''btn-primary'', but this button itself only causes the comment form to display, so is ''btn-secondary''. The  __Post__ button in the comment form is ''btn-primary'' because it actually causes the action.
* Although clicking the __Clear all caches__ button is destructive in the sense that it deletes files in the caches, this button can be ''btn-primary'' because clearing the caches is a positive action (to remove unwanted files and use updated content, etc.).

!! Questions
* Where is the limit between significant and insignificant changes? {sign user="Chealer9" datetime="2018-06-21T17:14:46+00:00"}
** I don't know of a criteria yet but I would say that for any case where there is a question, it should be classified as signficant. {sign user="chibaguy" datetime="2018-06-24T07:36:25+00:00"}
* Is it allowed to use ''btn-primary'' for confirming a non-destructive change, or to make a destructive change? {sign user="Chealer9" datetime="2018-06-21T17:14:46+00:00"}
** I think it's more appropriate to use the success color to confirm a non-destructive change; and I think it would be confusing and inconsistent to use btn-primary to make a destructive change. {sign user="chibaguy" datetime="2018-06-24T07:36:26+00:00"}
*** I understand that another color would be more appropriate; my question was whether it is acceptable, because if it is unacceptable, that is not clear in the table's current state. {sign user="Chealer9" datetime="2018-06-26T14:48:39+00:00"}
* Why is -+btn-secondary+- "cyber grape" when in default Bootstrap4 it is dark grey (#6c757d) ? {sign user="luci" datetime="2019-02-05T12:58:56+00:00"}
** The [https://getbootstrap.com/docs/4.2/components/buttons/|Bootstrap docs] say "Bootstrap includes several predefined button styles, each serving its own semantic purpose" but doesn't give any guidance on the use. The semantic purpose can be inferred from the button class name and color, except in the case of -+btn-secondary+-. A rationale can be seen for -+btn-danger+- being red (in our cultural context anyway), but there isn't a particular rationale for -+btn-secondary+- being dark grey. IIRC, the button's color change in Tiki was to give it a color like the other buttons have and not a gray shade. Maybe the change was also to give it some relationship to -+btn-primary+- and its color, which is blue by default, in the same way there is a color relationship between -+btn-warning+- and -+btn-danger+-. {sign user="chibaguy" datetime="2019-02-05T13:57:49+00:00"}